feat: add qvariantToCmd helper function#114
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Jun 27, 2025
Merged
Conversation
1. Added new helper function qvariantToCmd to properly format QVariant values for command line usage 2. Modified context menu handling to use the new helper when copying values 3. Ensures boolean and numeric values are copied without quotes while strings remain quoted 4. Fixes issue where raw QVariant values could cause syntax errors in command usage feat: 添加 qvariantToCmd 辅助函数 1. 新增 qvariantToCmd 辅助函数,用于将 QVariant 值格式化为适合命令行使用 的格式 2. 修改上下文菜单处理逻辑,使用新辅助函数复制值 3. 确保布尔值和数值不加引号复制,而字符串保持引号包裹 4. 修复原始 QVariant 值可能导致命令语法错误的问题
deepin pr auto review关键摘要:
是否建议立即修改: |
Reviewer's GuideIntroduces a "qvariantToCmd" helper to format QVariant values for shell commands—unquoted for booleans and numbers, quoted for strings—and updates context-menu copy actions to use it, thereby preventing syntax errors when copying raw QVariant values. Sequence diagram for context menu copy value action updatesequenceDiagram
actor User
participant Content
participant ValueHandler
participant ConfigGetter
participant QApplication
participant QClipboard
User->>Content: Right-click (custom context menu)
Content->>ValueHandler: new ValueHandler(appid, resource, subpath)
Content->>ConfigGetter: createManager()
Content->>ConfigGetter: value(key)
ConfigGetter-->>Content: QVariant value
Content->>Helper: qvariantToCmd(QVariant value)
Helper-->>Content: QString formattedValue
Content->>QApplication: clipboard()
Content->>QClipboard: setText(formattedValue) (on copy action)
Class diagram for qvariantToCmd helper additionclassDiagram
class Helper {
+static QString qvariantToCmd(const QVariant &v)
}
Helper : static QString qvariantToCmd(const QVariant &v)
Helper : static QVariant stringToQVariant(const QString &s)
Helper : static QStringList translationDirs()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Jun 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
values for command line usage
values
strings remain quoted
command usage
feat: 添加 qvariantToCmd 辅助函数
的格式
Summary by Sourcery
Introduce qvariantToCmd helper to format QVariant values for command-line use and update context menu actions to use it, ensuring correct quoting behavior and preventing syntax errors.
New Features:
Bug Fixes:
Enhancements: