fix: remove exit on postinst reload failure#126
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Aug 29, 2025
Merged
fix: remove exit on postinst reload failure#12618202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Removed the exit 1 command when configuration reload fails in postinst script to comply with Debian post-installation script standards. Post-installation scripts should not exit abnormally as it can break package management operations. The error logging and message output are preserved to ensure proper error reporting without interrupting the package installation process. fix: 移除 postinst 重载失败时的退出操作 移除 postinst 脚本中配置重载失败时的 exit 1 命令,以符合 Debian 安装后脚 本规范。安装后脚本不应异常退出,否则可能破坏包管理操作。保留错误日志和消 息输出功能,确保在不中断包安装过程的情况下进行正确的错误报告。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe post-installation script no longer aborts the package installation on configuration reload failures; instead, it logs errors and outputs messages while allowing the installation process to continue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning
|
robertkill
approved these changes
Aug 29, 2025
mhduiy
approved these changes
Aug 29, 2025
liujianqiang-niu
approved these changes
Aug 29, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, liujianqiang-niu, mhduiy, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the exit 1 command when configuration reload fails in postinst
script to comply with Debian post-installation script standards.
Post-installation scripts should not exit abnormally as it can break
package management operations. The error logging and message output
are preserved to ensure proper error reporting without interrupting the
package installation process.
fix: 移除 postinst 重载失败时的退出操作
移除 postinst 脚本中配置重载失败时的 exit 1 命令,以符合 Debian 安装后脚
本规范。安装后脚本不应异常退出,否则可能破坏包管理操作。保留错误日志和消
息输出功能,确保在不中断包安装过程的情况下进行正确的错误报告。
Summary by Sourcery
Bug Fixes: