fix: set minimum section size for export view header#128
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Sep 2, 2025
Merged
fix: set minimum section size for export view header#12818202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
|
Warning
详情 {
"export": {
"dconfig-center/dde-dconfig-editor/oemdialog.cpp": {
"a": [
" m_exportView->header()->setSectionResizeMode(QHeaderView::ResizeToContents);"
],
"b": [
" m_exportView->header()->setMinimumSectionSize(400);"
]
}
}
} |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjust signal handling in dde-dconfig-daemon to catch only termination signals and enforce a 400px minimum section width for the OEM export view header. Sequence diagram for updated signal handling in dde-dconfig-daemonsequenceDiagram
participant OS as Operating System
participant Daemon as dde-dconfig-daemon
OS->>Daemon: Send SIGTERM or SIGINT
Daemon->>Daemon: Handle termination signal (reset handler)
Daemon->>Daemon: Perform cleanup and exit
Class diagram for OEMDialog export view header updateclassDiagram
class OEMDialog {
- QTreeView* m_exportView
- DSuggestButton* m_exportBtn
+ OEMDialog(QWidget *parent)
}
class QTreeView {
}
class QHeaderView {
+ setMinimumSectionSize(int)
}
OEMDialog --> QTreeView : contains
QTreeView --> QHeaderView : header()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Changed the section resize mode from ResizeToContents to setting a minimum section size of 400 pixels for the export view header in OEMDialog. This prevents the header sections from becoming too narrow when resizing, ensuring better readability and usability of the interface. fix: 设置导出视图表头的最小分区大小 将OEMDialog中导出视图表头的分区调整模式从ResizeToContents改为设置最小分 区大小为400像素。这可以防止调整大小时表头分区变得过窄，确保更好的界面可 读性和可用性。
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider making the minimum section size a configurable constant or compute it dynamically to better accommodate varying UI layouts instead of hardcoding 400.
- When installing handlers for SIGTERM and SIGINT, consider preserving or chaining existing handlers and logging shutdown context to ensure a truly graceful termination.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the minimum section size a configurable constant or compute it dynamically to better accommodate varying UI layouts instead of hardcoding 400.
- When installing handlers for SIGTERM and SIGINT, consider preserving or chaining existing handlers and logging shutdown context to ensure a truly graceful termination.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Warning
详情 {
"export": {
"dconfig-center/dde-dconfig-editor/oemdialog.cpp": {
"a": [
" m_exportView->header()->setSectionResizeMode(QHeaderView::ResizeToContents);"
],
"b": [
" m_exportView->header()->setMinimumSectionSize(400);"
]
}
}
} |
18202781743
changed the title
mhduiy
approved these changes
Sep 1, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the section resize mode from ResizeToContents to setting
a minimum section size of 400 pixels for the export view header in
OEMDialog. This prevents the header sections from becoming too narrow
when resizing, ensuring better readability and usability of the
interface.
fix: 设置导出视图表头的最小分区大小
将OEMDialog中导出视图表头的分区调整模式从ResizeToContents改为设置最小分
区大小为400像素。这可以防止调整大小时表头分区变得过窄，确保更好的界面可
读性和可用性。