feat: add ownership option to device formatting#36
Merged
Johnson-zs merged 1 commit intolinuxdeepin:masterfrom Jul 28, 2025
Merged
feat: add ownership option to device formatting#36Johnson-zs merged 1 commit intolinuxdeepin:masterfrom
Johnson-zs merged 1 commit intolinuxdeepin:masterfrom
Conversation
- Updated the device formatting options to include a new parameter "take-ownership" set to true. - This enhancement allows for better management of device ownership during formatting. Log: Added ownership option to device formatting. Bug: https://pms.uniontech.com/bug-view-325935.html
Reviewer's GuideThis PR enhances the device formatting routine by extending the formatting options map to include a new "take-ownership" parameter set to true, enabling ownership management during format operations. Class diagram for updated device formatting options in MainWindowclassDiagram
class MainWindow {
+void formatDevice()
}
class MainPage {
+QString getLabel()
+QString getSelectedFs()
+bool shouldErase()
}
class Blk {
+void format(QString fs, QVariantMap opt)
+QDBusError lastError()
}
MainWindow --> MainPage : uses
MainWindow --> Blk : uses
%% Highlight the change: opt now includes "take-ownership"
note for MainWindow "formatDevice now adds { 'take-ownership': true } to options map for format() call"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
Johnson-zs
approved these changes
Jul 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Added ownership option to device formatting.
Bug: https://pms.uniontech.com/bug-view-325935.html
Summary by Sourcery
New Features: