sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#52

Summary by Sourcery

Bug Fixes:

• Prevent potential dangling signal-slot connections by disconnecting the password line edit when the authentication widget is destroyed.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the AuthPassword widget safely disconnects its line edit signal connections upon destruction to prevent potential use-after-free or stray signal issues.

Updated class diagram for AuthPassword destructor cleanup

classDiagram
class AuthPassword {
  - m_lineEdit : QLineEdit*
  - m_resetPasswordMessageVisible : bool
  + ~AuthPassword()
}

class QLineEdit {
}

AuthPassword --> QLineEdit : owns and disconnects signals from

Loading

File-Level Changes

Change	Details	Files
Safely disconnect line edit signals in AuthPassword destructor.	Added an explicit disconnection of the line edit's signal connections from the AuthPassword object in the destructor before performing other cleanup logic	src/session-widgets/auth_password.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

这是一个很好的改进，我来分析一下这个代码变更的优缺点：

1. 代码安全性和稳定性改进：

• 这个修改解决了一个潜在的崩溃问题。在Qt中，当QWidget析构时会自动调用clearFocus()，这会触发focusChanged信号。
• 如果此时仍有连接的槽函数在操作成员变量，可能会导致访问已释放的内存，从而引发崩溃。
• 通过在析构函数中显式断开连接，可以确保在对象销毁前不会有信号触发槽函数。

2. 代码质量：

• 添加了清晰的注释，解释了为什么需要这个修改，这是很好的编程实践。
• 修改位置恰当，在析构函数开始处就断开连接，避免后续操作可能引发的问题。

3. 建议的额外改进：

• 可以考虑使用更具体的disconnect()语法，而不是断开所有连接：

  m_lineEdit->disconnect(SIGNAL(focusChanged()), this, SLOT(onFocusChanged()));

  这样更明确地指出要断开哪个具体的信号-槽连接，便于代码维护。

• 可以考虑使用Qt5的新式连接语法，这样在编译时就能检查信号和槽的有效性：

  disconnect(m_lineEdit, &QLineEdit::focusChanged, this, &AuthPassword::onFocusChanged);

4. 性能考虑：

• 这个修改对性能的影响微乎其微，因为：
  • disconnect()操作非常轻量
  • 只在对象销毁时执行一次
  • 避免了潜在的崩溃，从整体上提高了程序稳定性

总的来说，这是一个很好的防御性编程实践，有效提高了代码的稳定性和安全性。建议的额外改进主要是为了代码的可维护性和类型安全。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment