sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#53

Summary by Sourcery

Bug Fixes:

• Fix lock screen flow so the user list is made visible before triggering the locked state, preventing direct transition to the password entry screen.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure the lock screen shows the user list UI before emitting the lock-state change, preventing an immediate jump to the password entry screen when switching users or waking from standby.

Sequence diagram for updated lock screen user list visibility before lock state change

sequenceDiagram
    actor User
    participant LockContent
    participant LockModel
    participant LockController

    User->>LockContent: pushUserFrame()
    activate LockContent

    Note over LockContent: Updated behavior
    LockContent->>LockModel: setVisible(true)
    LockModel-->>LockContent: visibility updated

    LockContent-->>LockController: requestLockStateChange(true)
    deactivate LockContent

    LockController->>LockModel: enterLockState()
    LockModel-->>User: showUserListUI()
    LockController-->>User: allowPasswordEntryAfterUserSelection()

Loading

File-Level Changes

Change	Details	Files
Adjust lock-state transition sequence so the user list view becomes visible before the lock signal is emitted.	Make the user list model visible before triggering a lock state change Document in comments that the user list must be shown prior to locking to avoid going straight to the password screen	src/session-widgets/lockcontent.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来帮你分析这段代码的变更：

1. 代码逻辑变更分析：

• 移除了原来在 SessionManagerInter::LockedChanged 信号处理中的锁屏逻辑
• 将锁屏逻辑移到了 Login1SessionSelf::ActiveChanged 信号处理中
• 条件判断从原来的 "locked && !m_model->visible()" 改为 "active && !m_model->visible()"

2. 代码质量改进建议：

• 代码缩进不一致，if 语句下的 m_model->showLockScreen() 缩进过多，建议统一使用 4 个空格缩进
• 建议在条件判断前添加注释说明为什么要在 active 状态下显示锁屏

3. 代码性能考虑：

• 从性能角度来看，这个改动是合理的。ActiveChanged 信号可能比 LockedChanged 信号更准确地反映了系统的实际状态
• 避免了重复的信号处理逻辑

4. 代码安全性分析：

• 这个改动本身不会带来明显的安全隐患
• 建议在 m_model->showLockScreen() 调用前添加额外的状态检查，确保系统确实需要显示锁屏

5. 改进建议：

#ifdef ENABLE_DSS_SNIPE
        // 当会话变为活跃状态且锁屏未显示时，显示锁屏界面
        if (active && !m_model->visible()) {
            // 添加额外的状态检查
            if (m_model->currentModeState() != ModeState::ShuttingDown) {
                m_model->showLockScreen();
            }
        }
#endif

6. 其他建议：

• 考虑将 ENABLE_DSS_SNIPE 相关的逻辑封装成单独的方法，提高代码可维护性
• 建议添加日志记录，便于调试和问题追踪
• 可以考虑添加单元测试来验证这个逻辑变更的正确性

这个改动总体上是合理的，但建议按照上述建议进一步完善代码的健壮性和可维护性。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment