Skip to content

fix: avoid error messages when service condition checks fail #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yixinshark merged 1 commit into from
Feb 4, 2026
Merged

fix: avoid error messages when service condition checks fail #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions systemd/dde-session-pre.target.wants/dde-quick-login@x11.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@ After=dde-session@x11.service
PartOf=dde-session-pre.target
Before=dde-session-pre.target

# only in quick login mode and x11
ConditionEnvironment=DDE_QUICKLOGIN=true
ConditionEnvironment=XDG_SESSION_TYPE=%I

# SuccessExitStatus=0,launch dde-lock.service
OnSuccess=dde-lock.service dde-version-checker@quick-login.service dde-autostart@quick-login.service

[Service]
Slice=session.slice
Type=notify
# only in quick login mode and x11
ExecCondition=/bin/sh -c '[ "$DDE_QUICKLOGIN" = "true" ] || exit 255'
ExecCondition=/bin/sh -c '[ "$XDG_SESSION_TYPE" = "%I" ] || exit 255'
ExecStart=/usr/bin/dde-quick-login
SuccessExitStatus=0
Restart=on-failure
Expand Down
3 changes: 3 additions & 0 deletions tools/dde-version-checker/dde-version-checker@quick-login.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
Description=dde-version-checker service (after quick login)
CollectMode=inactive-or-failed

# only in quick login mode
ConditionEnvironment=DDE_QUICKLOGIN=true

[Service]
Type=simple
ExecStart=/usr/bin/dde-version-checker