Skip to content

fix: Update version to 6.5.29#182

Closed
JWWTSL wants to merge 0 commit intolinuxdeepin:masterfrom
JWWTSL:master
Closed

fix: Update version to 6.5.29#182
JWWTSL wants to merge 0 commit intolinuxdeepin:masterfrom
JWWTSL:master

Conversation

@JWWTSL
Copy link
Contributor

@JWWTSL JWWTSL commented Nov 21, 2025

Summary by Sourcery

Bump deepin-calculator package version to 6.5.29.1 across all architecture manifests and update the Debian changelog.

Chores:

  • Update package version from 6.5.28.1 to 6.5.29.1 in arm64, loong64, sw64, and default linglong YAML files
  • Refresh Debian changelog to reflect the new version

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

TAG Bot

TAG: 6.5.29
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps deepin-calculator version from 6.5.28.1 to 6.5.29.1 across all distribution manifests and updates the Debian changelog.

File-Level Changes

Change Details Files
Update version field in distribution manifests
  • Increment version from 6.5.28.1 to 6.5.29.1 in ARM64, generic, Loong64, and SW64 YAML files
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml
sw64/linglong.yaml
Refresh Debian changelog entry
  • Add or update changelog entry reflecting new version 6.5.29.1
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@lzwind lzwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要解决 ci失败问题

@JWWTSL JWWTSL force-pushed the master branch 2 times, most recently from 5072239 to 388a495 Compare November 21, 2025 01:46
@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个diff进行仔细审查:

  1. 版本更新相关:
  • 所有平台的linglong.yaml文件(arm64、loong64、sw64)都统一将版本从6.5.28.1更新到6.5.29.1
  • debian/changelog也相应更新,记录了版本变更信息
  • 这些修改都是同步的,没有问题
  1. 代码逻辑改进(basicmodule.cpp):
// 修改前:
if (m_expressionBar->getInputEdit()->getMemoryAnswer().first) //如果输入栏中可计算出结果
    qInfo() << "Generating memory data from keypad";
    m_memoryPublic->generateData(m_expressionBar->getInputEdit()->getMemoryAnswer().second);

// 修改后:
// 仅当输入栏存在可计算结果时才执行MS存储,避免将无效表达式(如未完结的"89×")错误存为0
if (m_expressionBar->getInputEdit()->getMemoryAnswer().first) { // 如果输入栏中可计算出结果
    qInfo() << "Generating memory data from keypad";
    m_memoryPublic->generateData(m_expressionBar->getInputEdit()->getMemoryAnswer().second);
}

改进意见:

  1. 代码质量改进:

    • 添加了大括号{}使代码块更清晰,这是很好的实践
    • 添加了更详细的中文注释,说明了代码的目的和避免的问题
    • 代码缩进更加规范
  2. 逻辑安全性改进:

    • 原代码和修改后的代码逻辑本质上是一样的,都是先检查表达式是否可计算
    • 修改后的代码通过添加注释更清晰地说明了这个检查的目的:避免将无效表达式错误存为0
    • 这是一个很好的防御性编程实践
  3. 性能方面:

    • 没有性能相关的改动,代码执行效率保持不变
  4. 其他建议:

    • 可以考虑将m_expressionBar->getInputEdit()->getMemoryAnswer()的结果缓存到临时变量中,避免重复调用
    • 例如:
    auto memoryAnswer = m_expressionBar->getInputEdit()->getMemoryAnswer();
    if (memoryAnswer.first) {
        qInfo() << "Generating memory data from keypad";
        m_memoryPublic->generateData(memoryAnswer.second);
    }

总体来说,这是一个很好的代码改进,主要提高了代码的可读性和维护性,通过添加注释使代码意图更加清晰。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants