feat: hide specific version of UFS#178
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/1071from Oct 10, 2025
Merged
feat: hide specific version of UFS#178deepin-bot[bot] merged 1 commit intolinuxdeepin:release/1071from
deepin-bot[bot] merged 1 commit intolinuxdeepin:release/1071from
Conversation
only shows USF and hide the versions. Log: as above. Task: https://pms.uniontech.com/task-view-382543.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSimplify UFS interface labeling by collapsing version-specific checks into a single generic UFS label. Class diagram for updated DeviceStorage::getDiskInfoInterface() logicclassDiagram
class DeviceStorage {
+void getDiskInfoInterface(devicePath: QString, interface: QString)
}
class Utils {
+QString readContent(path: QString)
}
DeviceStorage --> Utils: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review这段代码审查如下:
改进建议:
if (spec_version.contains("300")) {
interface = "UFS 3.0";
} else if (spec_version.contains("310")) {
interface = "UFS 3.1";
} else if (spec_version.contains("400")) {
interface = "UFS 4.0";
}
// 统一返回UFS接口类型,不区分具体版本
if (spec_version.contains("300") || spec_version.contains("310") || spec_version.contains("400")) {
interface = "UFS";
}
QMap<QString, QString> ufsVersionMap = {
{"300", "UFS 3.0"},
{"310", "UFS 3.1"},
{"400", "UFS 4.0"}
};
for (auto it = ufsVersionMap.constBegin(); it != ufsVersionMap.constEnd(); ++it) {
if (spec_version.contains(it.key())) {
interface = it.value();
break;
}
}这样的改进既保持了代码的清晰性,又便于后续添加新的UFS版本,同时提高了代码的可维护性。 |
max-lvs
approved these changes
Oct 10, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only shows USF and hide the versions.
Log: as above.
Task: https://pms.uniontech.com/task-view-382543.html
Summary by Sourcery
Enhancements: