fix: Fix non-reproducible builds#180
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Oct 23, 2025
Merged
Conversation
Skip build rpath when the build type is set to "Release" to ensure reproducible builds.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the CMake configuration to disable setting the build rpath when building in Release mode, ensuring reproducible release builds. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个CMakeLists.txt的修改进行审查:
改进建议:
# Skip build rpath for reproducible release build
# Note: This may affect runtime library search path
# Ensure all necessary libraries are in standard system paths
if(CMAKE_BUILD_TYPE STREQUAL "Release")
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()
# Add option to control RPATH behavior
option(SKIP_RPATH_IN_RELEASE "Skip RPATH in Release builds" ON)
if(CMAKE_BUILD_TYPE STREQUAL "Release" AND SKIP_RPATH_IN_RELEASE)
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()
if(CMAKE_BUILD_TYPE STREQUAL "Release" AND NOT CMAKE_CROSSCOMPILING)
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()这些改进可以让代码更加健壮和可配置,同时提供更好的文档说明。 |
lzwind
approved these changes
Oct 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip build rpath when the build type is set to "Release" to ensure reproducible builds.
Summary by Sourcery
Build: