refactor: Service safety rectification#181
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Oct 30, 2025
Merged
refactor: Service safety rectification#181deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
There was a problem hiding this comment.
Sorry @wangrong1069, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
lzwind
previously approved these changes
Oct 27, 2025
- Replace com.deepin.diskmanager policy with com.deepin.pkexec.deepin-diskmanager - Update all translation files to reflect new policy filename - Modify CMakeLists.txt to use deepin-policy-ts-convert for policy file generation - Update desktop file handling with deepin-desktop-ts-convert - Change authorization check in diskmanagerservice.cpp to use new action ID - Update debian/control to include pkexec dependency and deepin-gettext-tools - Fix installation paths for USB scripts from openconnect to deepin-diskmanager - Remove hardcoded translations from policy file, rely on translation system - Update DBus configuration to remove own policy requirement This migration improves security and follows modern authentication best practices.
deepin pr auto review我来分析一下这个 Git diff 的内容,主要涉及许可证文件格式更新、构建系统修改和权限策略调整。
总体建议:
没有发现明显的性能问题或安全隐患。改动主要涉及构建和部署流程的优化。 |
lzwind
approved these changes
Oct 30, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration improves security and follows modern authentication best practices.