feat: support xps #200
Merged
deepin-bot[bot] merged 4 commits intolinuxdeepin:masterfrom Nov 12, 2025
Merged
Conversation
Log: as title
- show PDF, DJVU, DOCX, XPS on the home page banner and app description - include .xps in open dialog filters and desktop MimeType registration - update EN/ZH manuals plus plan constraints to reflect XPS coverage - refresh prompt instructions to avoid touching translation resources Log: as title task: https://pms.uniontech.com/task-view-383459.html
bc69483 to
e650057
Compare
detect libgxps/cairo/glib via pkg-config and auto-toggle XPS_SUPPORT link reader target with gxps stack and propagate include/compile flags declare runtime/build deps in debian control and linglong manifest document clean reconfigure path to refresh resolved XPS availability Log: as title task: https://pms.uniontech.com/task-view-383459.html
- add XpsDocumentAdapter to manage libgxps/cairo handles via RAII - remove the old manual XpsDocument implementation and update document.pri - hook the adapter into DocumentFactory to load XPS files - normalize parsed page sizes with gxps_page_get_size fallback - clamp render task dimensions in BrowserPage/PageRenderThread to avoid blank frames task:https://pms.uniontech.com/task-view-383459.html
deepin pr auto review我来对这次代码变更进行审查,主要关注XPS文档支持的实现:
总体来说,这次代码变更质量较高,实现了XPS文档支持的同时,保持了代码的可维护性和稳定性。主要改进点在于使用了libgxps库替代了原有的自定义解析实现,这是一个明智的选择。 |
lzwind
approved these changes
Nov 12, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace legacy parser with libgxps adapter
task: https://pms.uniontech.com/task-view-383459.html