fix: improve FindWidget position update logic#202
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Nov 13, 2025
Merged
fix: improve FindWidget position update logic#202deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
- Refactor position update in FindWidget to account for parent window dimensions. - Ensure correct positioning relative to the parent window or fallback to screen geometry if no parent is present. This change enhances the usability of the FindWidget by ensuring it appears correctly in relation to its parent window. bug: https://pms.uniontech.com/bug-view-339997.html
deepin pr auto review我来对这个diff变更进行详细分析:
void FindWidget::updatePosition()
{
qCDebug(appLog) << "Updating find widget position, yOffset:" << m_yOff;
// 添加空指针检查
if (!m_parentWidget) {
qCWarning(appLog) << "Parent widget is null";
return;
}
// 确保查找窗口不会超出父窗口范围
int parentWidth = m_parentWidget->width();
int widgetWidth = this->width();
int x = qMax(10, parentWidth - widgetWidth - 10);
this->move(x, m_yOff + 10);
this->show();
this->raise();
}
这个修改总体上是好的,但需要增加一些安全检查来提高代码的健壮性。 |
lzwind
approved these changes
Nov 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcenerge |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enhances the usability of the FindWidget by ensuring it appears correctly in relation to its parent window.
bug: https://pms.uniontech.com/bug-view-339997.html