feat: [xps] harmonize metadata fields and outline diagnostics#204
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Nov 13, 2025
Merged
feat: [xps] harmonize metadata fields and outline diagnostics#204deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
align XPS core property keys with DocSheet expectations and drop hardcoded fallbacks to restore keyword exposure in file info
prefer document-supplied author/keyword metadata in DocSheet, logging owner-based fallbacks for traceability
add debugging hooks for missing XPS core properties and empty outline structures to ease QA validation
task:https://pms.uniontech.com/task-view-383459.html
deepin pr auto review我来对这段代码的修改进行审查分析:
具体建议:
QString normalizedString(const gchar *value, const QString &fallback = QString())
{
if (!value) return fallback; // 增加空指针检查
QString result = QString::fromUtf8(value).trimmed();
return result.isEmpty() ? fallback : result;
}
const auto setPropertyWithLog = [&](const QString &key, const gchar *value) {
if (!value) { // 增加空指针检查
qCDebug(appLog) << "XPS metadata missing field:" << key;
return;
}
const QString text = normalizedString(value);
if (text.isEmpty()) {
qCDebug(appLog) << "XPS metadata empty field:" << key;
}
props[key] = text;
};
QString author = propertys.value("Author").toString();
if (author.isEmpty()) {
author = propertys.value("Creator").toString();
}
if (author.isEmpty()) {
author = fileInfo.owner();
if (!author.isEmpty()) { // 增加非空检查
qCDebug(appLog) << "Using file owner as fallback author for document";
}
}
tFileInfo.auther = author;这些修改提高了代码的健壮性和可维护性,同时增加了更多的错误处理和日志记录,有助于问题诊断和调试。整体来看,这是一次积极的代码改进。 |
lzwind
approved these changes
Nov 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task:https://pms.uniontech.com/task-view-383459.html