chore: Update version to 6.5.43 and adjust PDF library versioning#206
Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom Nov 13, 2025
Merged
chore: Update version to 6.5.43 and adjust PDF library versioning#206lzwind merged 1 commit intolinuxdeepin:masterfrom
lzwind merged 1 commit intolinuxdeepin:masterfrom
Conversation
- Bump the version of deepin-reader to 6.5.43 across multiple architecture YAML files. - Modify CMakeLists.txt to set PDF_LIB_VERSION based on the detected Qt version. This update ensures consistency in versioning and improves compatibility with different Qt versions.
|
TAG Bot TAG: 6.5.43 |
deepin pr auto review我来对这个diff进行审查:
if (QT_VERSION_MAJOR MATCHES 5)
set(PDF_LIB_VERSION 5)
else()
set(PDF_LIB_VERSION "")
endif()优点:
建议:
优点:
建议:
优点:
建议:
总体建议:
这些修改整体上是合理的,主要关注了版本兼容性和功能改进,但需要更多的文档和测试支持。 |
lzwind
approved these changes
Nov 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update ensures consistency in versioning and improves compatibility with different Qt versions.