Conversation
add XPS_SUPPORT_ENABLED to all Dr::Xps Log: as title
deepin pr auto review我来对这个diff进行代码审查:
inline bool isXpsDocument() const {
#ifdef XPS_SUPPORT_ENABLED
return m_fileType == Dr::XPS;
#else
return false;
#endif
}
总的来说,这个改动是合理的,主要改进了代码的条件编译处理,但还可以通过一些小的重构来提高代码的可维护性和一致性。 |
lzwind
approved these changes
Nov 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add XPS_SUPPORT_ENABLED to all Dr::Xps
Log: as title