feat: use external deepin-pdfium and remove bundled submodule#221
feat: use external deepin-pdfium and remove bundled submodule#221hillwoodroc wants to merge 0 commit intolinuxdeepin:masterfrom
Conversation
|
Hi @hillwoodroc. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5e59d46 to
4d3b57d
Compare
|
因为兼容性的原因,不能合入。我们在最新版本需要同时支持Qt5与Qt6同时构建包。 |
|
为什么不在旧环境里面打包一个旧版本的 deepin-pdfium ?用内置死代码对新环境非常不友好。 |
|
TAG Bot New tag: 6.5.47 |
|
TAG Bot New tag: 6.5.48 |
|
TAG Bot New tag: 6.5.49 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hillwoodroc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-pdfium has been continuously maintained and updated, so there is no need to bundle an older version inside the project.
deepin-pdfium 一直都在正常维护更新,为什么要内置一个更旧的版本而不是在项目里面链接 deepin-pdfium ?
Log: This fix replaces the built-in deepin-pdfium with the system-provided PkgConfig-based deepin-pdfium package.