refactor: reduce log level from info to debug#68
Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom Sep 26, 2025
Merged
Conversation
18202781743
previously approved these changes
Sep 26, 2025
Changed logging statements from qCInfo to qCDebug in policy checking and D-Bus hook functions to reduce log noise in production environments. Added DTK logging framework dependencies and initialization to enhance logging capabilities. The info-level logs were too verbose for normal operation but are still useful for debugging purposes. The changes include: 1. Replace qCInfo with qCDebug in policy.cpp for permission checking logs 2. Replace qCInfo with qCDebug in qtdbushook.cpp for D-Bus message processing logs 3. Add DTK Core component dependency in CMakeLists.txt 4. Register console and journal appenders in main.cpp for DTK logging refactor: 将日志级别从信息降为调试 将策略检查和D-Bus钩子函数中的日志语句从qCInfo改为qCDebug,以减少生产环境 中的日志噪音。添加DTK日志框架依赖和初始化以增强日志功能。信息级别的日志 在正常操作中过于冗长,但在调试时仍然有用。 更改包括: 1. 在policy.cpp中将权限检查日志从qCInfo改为qCDebug 2. 在qtdbushook.cpp中将D-Bus消息处理日志从qCInfo改为qCDebug 3. 在CMakeLists.txt中添加DTK Core组件依赖 4. 在main.cpp中注册控制台和日志应用器以支持DTK日志
18202781743
approved these changes
Sep 26, 2025
deepin pr auto review根据提供的代码差异,我来对代码进行审查,并提出改进意见:
以上建议旨在提高代码的质量、性能和可维护性。根据实际项目需求,可以选择性地实施这些建议。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed logging statements from qCInfo to qCDebug in policy checking and D-Bus hook functions to reduce log noise in production environments. Added DTK logging framework dependencies and initialization to enhance logging capabilities. The info-level logs were too verbose for normal operation but are still useful for debugging purposes.
The changes include:
refactor: 将日志级别从信息降为调试
将策略检查和D-Bus钩子函数中的日志语句从qCInfo改为qCDebug,以减少生产环境
中的日志噪音。添加DTK日志框架依赖和初始化以增强日志功能。信息级别的日志
在正常操作中过于冗长,但在调试时仍然有用。
更改包括: