Skip to content

feat: add debug and log configuration support#75

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Nov 14, 2025
Merged

feat: add debug and log configuration support#75
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Nov 14, 2025

Added debug configuration file and log viewer configuration for deepin- service-manager

  1. Install debug configuration file to /usr/share/deepin-debug-config
  2. Install log viewer configuration to /usr/share/deepin-log-viewer
  3. Added JSON configuration files for debug and log management
  4. Set application name to org.deepin.service.manager for proper identification

Log: Added debug and log configuration support for service manager

Influence:

  1. Verify debug configuration files are properly installed
  2. Test log viewer configuration is correctly placed
  3. Check application identification in system logs
  4. Validate debug tools can access service manager logs
  5. Test journal log collection for service manager

feat: 添加调试和日志配置支持

为 deepin-service-manager 添加调试配置文件和日志查看器配置

  1. 安装调试配置文件到 /usr/share/deepin-debug-config
  2. 安装日志查看器配置到 /usr/share/deepin-log-viewer
  3. 添加调试和日志管理的 JSON 配置文件
  4. 设置应用程序名称为 org.deepin.service.manager 以便正确识别

Log: 为服务管理器添加调试和日志配置支持

Influence:

  1. 验证调试配置文件是否正确安装
  2. 测试日志查看器配置是否正确放置
  3. 检查系统日志中的应用程序标识
  4. 验证调试工具能否访问服务管理器日志
  5. 测试服务管理器的日志收集功能

Added debug configuration file and log viewer configuration for deepin-
service-manager
1. Install debug configuration file to /usr/share/deepin-debug-config
2. Install log viewer configuration to /usr/share/deepin-log-viewer
3. Added JSON configuration files for debug and log management
4. Set application name to org.deepin.service.manager for proper
identification

Log: Added debug and log configuration support for service manager

Influence:
1. Verify debug configuration files are properly installed
2. Test log viewer configuration is correctly placed
3. Check application identification in system logs
4. Validate debug tools can access service manager logs
5. Test journal log collection for service manager

feat: 添加调试和日志配置支持

为 deepin-service-manager 添加调试配置文件和日志查看器配置
1. 安装调试配置文件到 /usr/share/deepin-debug-config
2. 安装日志查看器配置到 /usr/share/deepin-log-viewer
3. 添加调试和日志管理的 JSON 配置文件
4. 设置应用程序名称为 org.deepin.service.manager 以便正确识别

Log: 为服务管理器添加调试和日志配置支持

Influence:
1. 验证调试配置文件是否正确安装
2. 测试日志查看器配置是否正确放置
3. 检查系统日志中的应用程序标识
4. 验证调试工具能否访问服务管理器日志
5. 测试服务管理器的日志收集功能
@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个diff进行审查:

  1. 语法逻辑:
  • JSON配置文件格式正确,结构清晰
  • CMakeLists.txt的install命令语法正确
  • main.cpp中设置应用程序名称的代码语法正确
  1. 代码质量:
  • 配置文件结构清晰,有适当的缩进
  • 使用了版本号(V1.0)进行版本管理
  • 配置文件包含了必要的字段(name, group, submodules等)
  1. 代码性能:
  • 这些改动主要是配置文件的添加,对性能影响很小
  • main.cpp中添加的setApplicationName调用在程序启动时执行一次,性能影响可忽略
  1. 代码安全:
  • JSON配置文件中的路径使用了绝对路径(/usr/bin/deepin-service-manager),更安全
  • 配置文件权限控制需要确保正确设置
  • 建议检查新添加的配置文件权限是否合适

改进建议:

  1. 配置文件安全:
  • 建议在JSON配置文件中添加权限相关配置
  • 确保新添加的配置文件在安装时具有正确的权限设置
  1. 版本管理:
  • 建议使用更具体的版本号格式,如"1.0.0"而不是"V1.0"
  • 可以考虑添加配置文件的校验机制
  1. 路径处理:
  • CMakeLists.txt中的安装路径使用了变量,这是好的实践
  • 建议在JSON配置文件中也考虑使用相对路径或环境变量
  1. 日志配置:
  • deepin-log-config中的filter字段为空字符串,建议添加合适的过滤规则
  • 可以考虑添加更多日志相关的配置选项
  1. 文档:
  • 建议为新添加的配置文件添加注释说明
  • 可以考虑添加配置文件的示例文档

这些改动整体上是合理的,主要是添加了调试和日志相关的配置文件,有助于系统的调试和维护。只需要注意一些细节的完善即可。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, caixr23

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 877547c into linuxdeepin:master Nov 14, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants