Skip to content

fix: make version optional in release workflow and update RPM spec#108

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Jun 27, 2025
Merged

fix: make version optional in release workflow and update RPM spec#108
mhduiy merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Contributor

  1. Changed version parameter to optional in GitHub workflow to allow
    more flexible releases
  2. Updated RPM spec file with:
    • Added conditional source URL handling for Fedora
    • Improved formatting and metadata (License, URL)
    • Added %{?dist} macro to Release field
  3. These changes improve package maintainability and support different
    build environments

fix: 使发布工作流中的版本可选并更新 RPM 规范

  1. 将 GitHub 工作流中的版本参数改为可选,以实现更灵活的发布
  2. 更新 RPM 规范文件:
    • 为 Fedora 添加了条件式源 URL 处理
    • 改进了格式和元数据(许可证、URL)
    • 在 Release 字段中添加了 %{?dist} 宏
  3. 这些更改提高了软件包的可维护性并支持不同的构建环境

1. Changed version parameter to optional in GitHub workflow to allow
more flexible releases
2. Updated RPM spec file with:
   - Added conditional source URL handling for Fedora
   - Improved formatting and metadata (License, URL)
   - Added %{?dist} macro to Release field
3. These changes improve package maintainability and support different
build environments

fix: 使发布工作流中的版本可选并更新 RPM 规范

1. 将 GitHub 工作流中的版本参数改为可选,以实现更灵活的发布
2. 更新 RPM 规范文件:
   - 为 Fedora 添加了条件式源 URL 处理
   - 改进了格式和元数据(许可证、URL)
   - 在 Release 字段中添加了 %{?dist} 宏
3. 这些更改提高了软件包的可维护性并支持不同的构建环境
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • .github/workflows/call-auto-release.yml文件中,version参数的required属性从true改为false,需要确认这一改动是否符合预期,因为通常版本号是发布流程中必需的参数。
  • rpm/dtkcommon.spec文件中,Release字段现在使用了%{?dist},这会根据不同的发行版自动生成版本号,但需要确保这一改动不会影响RPM包的兼容性。
  • rpm/dtkcommon.spec文件中新增了URL字段,这是一个好的做法,有助于用户和自动化工具找到项目的源代码。
  • rpm/dtkcommon.spec文件中,Source0字段根据Fedora发行版使用了不同的源文件格式,这需要确保在非Fedora发行版上也能正确处理.orig.tar.xz文件。

是否建议立即修改:

  • 是,需要确认version参数的required属性改动是否符合业务逻辑,并确保Release字段和Source0字段的改动不会引入兼容性问题。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 66cd081 into linuxdeepin:master Jun 27, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants