feat: add reproducible build configuration#354
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Nov 14, 2025
Merged
feat: add reproducible build configuration#35418202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Contributor
|
Warning
|
1. Added CMAKE_SKIP_BUILD_RPATH=ON flag to DEB_CMAKE_EXTRA_FLAGS 2. Modified dh_auto_configure to include DEB_CMAKE_EXTRA_FLAGS 3. This ensures reproducible builds by skipping build-time RPATH 4. Improves package consistency across different build environments Influence: 1. Verify that builds are reproducible across different systems 2. Test package installation and runtime behavior remains unchanged 3. Confirm that RPATH is not embedded in binaries during build 4. Validate that the build process completes successfully with new flags feat: 添加可重复编译配置 1. 向 DEB_CMAKE_EXTRA_FLAGS 添加 CMAKE_SKIP_BUILD_RPATH=ON 标志 2. 修改 dh_auto_configure 以包含 DEB_CMAKE_EXTRA_FLAGS 3. 通过跳过构建时 RPATH 确保可重复编译 4. 提高不同构建环境下软件包的一致性 Influence: 1. 验证在不同系统上的构建是否可重复 2. 测试软件包安装和运行时行为保持不变 3. 确认构建过程中二进制文件未嵌入 RPATH 4. 验证使用新标志后构建过程成功完成
Contributor
|
Warning
|
Contributor
deepin pr auto review我来对这个 git diff 进行审查:
# 基础构建配置
DEB_CMAKE_EXTRA_FLAGS += -DCMAKE_SKIP_BUILD_RPATH=ON
# 其他配置选项
CONFIG_FLAGS = -DBUILD_TESTING=OFF -DBUILD_DOCS=ON -DDTK_VERSION=$(_PACK_VER)
override_dh_auto_configure:
dh_auto_configure -- $(DEB_CMAKE_EXTRA_FLAGS) $(CONFIG_FLAGS)
DEB_CMAKE_EXTRA_FLAGS += \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DWITH_HARDENING=ON
DEB_CMAKE_EXTRA_FLAGS ?= 总体来说,这个修改是为了实现可重现编译(reproducible builds),这是一个很好的实践。修改本身是合理的,但可以通过上述建议进一步改进代码的质量和安全性。 |
BLumia
approved these changes
Nov 14, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Influence:
feat: 添加可重复编译配置
Influence: