fix: improve SVG icon cache validation#268
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom May 26, 2025
Merged
Conversation
1. Added QFileInfo check for SVG file existence and lastModified validity before cache processing 2. Moved svgFileInfo creation outside conditional block for reuse 3. Ensures cache invalidation properly checks file modification times 4. Prevents potential cache issues with invalid file timestamps fix: 改进SVG图标缓存验证 1. 在缓存处理前添加对SVG文件存在性和最后修改时间的QFileInfo检查 2. 将svgFileInfo创建移到条件块外以便重用 3. 确保缓存失效时正确检查文件修改时间 4. 防止因无效文件时间戳导致的潜在缓存问题
deepin-ci-robot
added a commit
to linuxdeepin/qt6integration
that referenced
this pull request
May 23, 2025
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#268
Contributor
deepin pr auto review关键摘要:
是否建议立即修改:
|
mhduiy
approved these changes
May 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/qt6integration
that referenced
this pull request
May 26, 2025
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validity before cache processing
fix: 改进SVG图标缓存验证