Skip to content

feat: Support VERSION file#269

Merged
asterwyx merged 3 commits intolinuxdeepin:masterfrom
asterwyx:version
Jun 18, 2025
Merged

feat: Support VERSION file#269
asterwyx merged 3 commits intolinuxdeepin:masterfrom
asterwyx:version

Conversation

@asterwyx
Copy link
Contributor

Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang wangyixue@uniontech.com

asterwyx added 2 commits June 16, 2025 14:00
Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
Log: as title
Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jun 16, 2025
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#269
18202781743
18202781743 previously approved these changes Jun 16, 2025
Linglong does not use this now.

Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
@asterwyx asterwyx requested a review from 18202781743 June 16, 2025 07:32
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jun 16, 2025
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#269
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • .github/workflows/call-auto-release.yml文件中,workflow_dispatchworkflow_call的输入参数定义重复,可以考虑合并以简化代码。
  • CMakeLists.txt文件中,使用file(READ)读取VERSION文件并去除空白字符,这是一个好的做法,可以确保版本号的一致性。
  • .reuse/dep5文件中,新增了VERSIONVERSION.in文件的支持,这是一个合理的扩展,但需要确保这些文件在项目中正确使用。
  • .syncexclude文件中,新增了对VERSION文件的排除,这是一个合理的改动,可以避免不必要的同步。

是否建议立即修改:

  • 是,建议立即合并重复的输入参数定义,以提高代码的可维护性。
  • 是,建议检查新增的文件是否已经在项目中正确使用,并确保它们不会引入新的问题。
  • 是,建议确认VERSIONVERSION.in文件的使用是否符合项目的版本管理策略。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, asterwyx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asterwyx asterwyx merged commit 7cc0aeb into linuxdeepin:master Jun 18, 2025
18 of 19 checks passed
@asterwyx asterwyx deleted the version branch June 18, 2025 05:36
asterwyx pushed a commit to linuxdeepin/qt6integration that referenced this pull request Jun 18, 2025
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#269
asterwyx pushed a commit to linuxdeepin/qt6integration that referenced this pull request Jun 18, 2025
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants