Skip to content

Conversation

@ygerlach
Copy link
Contributor

This is just an internal change. There should be no (intended) visible change to the users.

I think the way tags are currently handled is horrific. I guess it works, but when one want to add or change something with the tags, one has to look up specific strings throughut the entire project. My goal is to improve that. That´s why i introduced the Tags enum. It works as flags, so in one Tags variable many Tag values can be held. It should also have all strings (and their parsing methods) related to tags in one place.

There would be another way to do this:
We could define a normal enum Tag and make the type not hold more than one Tag value. That could be implemented in a different class. Im not sure what is best in this case, hence this PR as RFC. To discuss this.

My main motivation to do this change, is to be able to add 1-2 new tags in future PRs in a simple manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant