Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an internal change. There should be no (intended) visible change to the users.
I think the way tags are currently handled is horrific. I guess it works, but when one want to add or change something with the tags, one has to look up specific strings throughut the entire project. My goal is to improve that. That´s why i introduced the
Tagsenum. It works as flags, so in oneTagsvariable many Tag values can be held. It should also have all strings (and their parsing methods) related to tags in one place.There would be another way to do this:
We could define a normal enum
Tagand make the type not hold more than one Tag value. That could be implemented in a different class. Im not sure what is best in this case, hence this PR as RFC. To discuss this.My main motivation to do this change, is to be able to add 1-2 new tags in future PRs in a simple manner.