Add support for addition/subtraction of Map data types #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host of new assignment operators.
Fixed typo in comments
…ecrement operators. They will be pursued later. Initial functionality of raw drecrement and increment finished (does not save the value back to source).
…s, but causes a panic on core dump currently.
… use on object numbers.
Adding documentation for the new supported operators to be merged in soon from the NewOps branch.
…code to handle all those over the original 256 limit.
…ll. Yeah I feel dumb.
…me I'm sure that is everything.
…g to go along with the multi-line comments.
# Conflicts: # src/curl.cc
…istdude-master # Conflicts: # src/curl.cc
Merging in my docker check to remain commit current
MAX_BASE_FUNC overflow causes function 256 (counting from 0) to overflow, creating a call to function 0 (run_gc)
Checking out from master, the function is `char_list()`. Checking `;function_info()[257][1]` should tell you the affected builtin if you're running a modified build.
Before:
```
;char_list("bob")
#-1:Input to EVAL (this == #-1), line 3: Incorrect number of arguments (expected 0; got 1)
... called from built-in function eval()
... called from lisdude#58:eval_cmd_string, line 19
... called from lisdude#58:eval*-d, line 13
(End of traceback)
```
After:
```
;char_list("bob")
=> {"b", "o", "b"}
```
fix MAX_BASE_FUNC overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality for adding two maps together and for subtracting one map from another. In the case of addition, the key/value pairs from the right map are added to the map on the left. Thus, if there is a key collision, the key/value pair on the right side of the addition operation will be in the resulting map, rather than the left hand side. In the case of subtraction, the keys from the map on the right hand side, are removed from the map on the left hand side. A copy of the left hand side map is returned, minus the removed keys. Any keys that do not exist will simply be ignored. Using the subtraction operation, you could easily find key intersections between two maps. The error messages are also updated to reflect that maps can be used in +/- operations.