Refactoring ES6, no new Buffer()#3
Open
nolan-vanmoortel wants to merge 3 commits intoliteserver:masterfrom
Open
Refactoring ES6, no new Buffer()#3nolan-vanmoortel wants to merge 3 commits intoliteserver:masterfrom
nolan-vanmoortel wants to merge 3 commits intoliteserver:masterfrom
Conversation
added 3 commits
February 2, 2019 15:20
REFACTOR TO ES6 LANGUAGE - DONE REFACTOR TEST TO USE CHAI - DONE
REFACTOR TO ES6 LANGUAGE - DONE REFACTOR TEST TO USE CHAI - DONE
Collaborator
|
Hi! Thank you for the contribution! Unhappily I cannot accept it on the master branch because it has so many changes, it adds new dependencies and many people still prefer the old Javascript. So I added a link to your version on the README for ES6 users. I also recommend using lower case letters on commit messages, unless your company requires the opposite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me begin by saying thank you for the work done.
Your module binn.js have been very helpful at MintT.
I made a refactoring using the latest concepts of ES6 and in particular on the new Buffer() which are deprecated.
I took advantage of the occasion to apply an eslint-airbnb and tests with chai.js.
-Vanmoortel Nolan