Fix DAK Publications Page 404 error caused by missing workflow IDs#554
Fix DAK Publications Page 404 error caused by missing workflow IDs#554
Conversation
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
🔍 Page Framework Compliance Check Results
🔍 SGEX Page Framework Compliance CheckerFound 25 routed page components ✅ WelcomePage: 5/5 (100%) - COMPLIANT ✅ SelectProfilePage: 5/5 (100%) - COMPLIANT ✅ DAKActionSelection: 5/5 (100%) - COMPLIANT ✅ DAKSelection: 5/5 (100%) - COMPLIANT ✅ OrganizationSelection: 5/5 (100%) - COMPLIANT ✅ DAKConfiguration: 5/5 (100%) - COMPLIANT ✅ DashboardRedirect: 5/5 (100%) - COMPLIANT ✅ DAKDashboardWithFramework: 5/5 (100%) - COMPLIANT ✅ TestDashboard: 5/5 (100%) - COMPLIANT ✅ TestingViewer: 5/5 (100%) - COMPLIANT ✅ CoreDataDictionaryViewer: 5/5 (100%) - COMPLIANT ✅ ComponentEditor: 5/5 (100%) - COMPLIANT ✅ ActorEditor: 5/5 (100%) - COMPLIANT ✅ BusinessProcessSelection: 5/5 (100%) - COMPLIANT
✅ BPMNViewer: 5/5 (100%) - COMPLIANT ✅ BPMNViewerTestComponent: 5/5 (100%) - COMPLIANT ✅ BPMNSource: 5/5 (100%) - COMPLIANT ✅ DecisionSupportLogicView: 5/5 (100%) - COMPLIANT ✅ DocumentationViewer: 5/5 (100%) - COMPLIANT ✅ PagesManager: 5/5 (100%) - COMPLIANT ✅ LandingPageWithFramework: 5/5 (100%) - COMPLIANT ✅ TestDocumentationPage: 5/5 (100%) - COMPLIANT
✅ NotFound: 5/5 (100%) - COMPLIANT 📊 COMPLIANCE SUMMARY✅ Fully Compliant: 23/25 📈 Overall Compliance: 92%
✅ COMPLIANCE CHECK PASSED Next StepsFor migration guidance, see Page Framework Documentation. |
🚀 Branch Preview Ready!Branch: 🌐 Preview URLs
The branch preview is automatically updated with each push to this branch. Note: Landing page deployment is handled separately via manual workflow. |
The DAK Publications Page was throwing 404 errors when trying to fetch workflow runs:
The issue was caused by the
getWorkflows()method ingithubService.jscreating workflow objects without the GitHub API's workflowidproperty. WhenPublications.jsattempted to callgetWorkflowRunsForWorkflow()with an undefined workflow ID, it resulted in a malformed API URL with double slashes (//runsinstead of/12345/runs).Changes Made
Updated
githubService.js:listRepoWorkflowsAPIidproperty required for subsequent API callsEnhanced
Publications.js:ghbuildWorkflow.idexists before making API callsBefore vs After
Before (Broken):
After (Fixed):
The Publications page will now properly display workflow build status indicators for DAK repositories without encountering 404 errors.
Fixes #553.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/owner/repo/contents/input%2Ffsh/usr/local/bin/node /home/REDACTED/work/sgex/sgex/node_modules/jest-worker/build/workers/processChild.js(http block)https://api.github.com/repos/owner/repo/contents/input%2Ffsh%2Fprofile.fsh/usr/local/bin/node /home/REDACTED/work/sgex/sgex/node_modules/jest-worker/build/workers/processChild.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.