Skip to content

Pass the version number from git tag to build.cmd on windows #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xianshijing-lk merged 1 commit into from
Jan 30, 2026
Merged

Pass the version number from git tag to build.cmd on windows #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 54 additions & 9 deletions .github/workflows/make-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,34 @@ jobs:
id: version
shell: bash
run: |
set -euo pipefail

if [[ -n "${{ github.event.inputs.version }}" ]]; then
VERSION="${{ github.event.inputs.version }}"
elif [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
VERSION="${GITHUB_REF#refs/tags/v}"
elif [[ "${{ github.ref_type }}" == "tag" ]]; then
# github.ref_name is e.g. "v0.2.4"
TAG="${{ github.ref_name }}"
VERSION="${TAG#v}"
else
VERSION="0.0.0-dev"
fi
echo "version=${VERSION}" >> $GITHUB_OUTPUT
echo "SDK Version: ${VERSION}"

# Basic validation: must not be empty, must not start with v, no spaces
if [[ -z "$VERSION" ]]; then
echo "ERROR: Derived version is empty"
exit 1
fi
if [[ "$VERSION" == v* ]]; then
echo "ERROR: Derived version still has leading 'v': $VERSION"
exit 1
fi
if [[ "$VERSION" =~ [[:space:]] ]]; then
echo "ERROR: Version contains whitespace: '$VERSION'"
exit 1
fi

echo "version=$VERSION" >> "$GITHUB_OUTPUT"
echo "SDK Version: $VERSION"

# ---------- vcpkg for Windows ----------
- name: Export GitHub Actions cache environment variables
Expand Down Expand Up @@ -130,8 +149,17 @@ jobs:
chmod +x build.sh
version="${{ steps.version.outputs.version }}"
bundleDir="sdk-out/livekit-sdk-${{ matrix.name }}-${version}"
if [[ -z "$version" ]]; then
echo "ERROR: version is empty"
exit 1
fi

./build.sh release-examples --bundle --prefix "$bundleDir"
if [[ "$version" == "0.0.0-dev" ]]; then
echo "ERROR: refusing to build release with fallback version: $version"
exit 1
fi

./build.sh release-examples --version "$version" --bundle --prefix "$bundleDir"

# List bundle contents
echo "Bundle contents:"
Expand All @@ -145,7 +173,8 @@ jobs:
$version = "${{ steps.version.outputs.version }}"
$bundleDir = "sdk-out/livekit-sdk-${{ matrix.name }}-$version"

.\build.cmd release-examples --version $version
if ([string]::IsNullOrWhiteSpace($version)) { throw "version is empty" }
.\build.cmd release-examples --version "$version"

# There is the missing step that generates LiveKitTargets.cmake in the install tree
# TODO(sxian): fix it after getting access to a windows machine
Expand Down Expand Up @@ -178,14 +207,30 @@ jobs:
id: version
shell: bash
run: |
set -euo pipefail
if [[ -n "${{ github.event.inputs.version }}" ]]; then
VERSION="${{ github.event.inputs.version }}"
elif [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
VERSION="${GITHUB_REF#refs/tags/v}"
elif [[ "${{ github.ref_type }}" == "tag" ]]; then
TAG="${{ github.ref_name }}"
VERSION="${TAG#v}"
else
VERSION="0.0.0-dev"
fi
echo "version=${VERSION}" >> $GITHUB_OUTPUT

if [[ -z "$VERSION" ]]; then
echo "ERROR: Derived version is empty"
exit 1
fi
if [[ "$VERSION" == v* ]]; then
echo "ERROR: Derived version still has leading 'v': $VERSION"
exit 1
fi
if [[ "$VERSION" =~ [[:space:]] ]]; then
echo "ERROR: Version contains whitespace: '$VERSION'"
exit 1
fi
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
echo "SDK Version: $VERSION"

- name: Download all artifacts
uses: actions/download-artifact@v4
Expand Down
Loading