Skip to content

fix the build.cmd to handle --version params #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xianshijing-lk merged 1 commit into from
Jan 30, 2026
Merged

fix the build.cmd to handle --version params #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,42 @@ if /I "%1"=="help" goto usage
if "%1"=="-h" goto usage
if "%1"=="--help" goto usage

set "CMD=%1"
shift
goto parse_args
set "CMD="
set "LIVEKIT_VERSION="

:parse_args
if "%1"=="" goto after_parse
:parse_all
if "%~1"=="" goto after_parse

if "%1"=="--version" (
:: 1. Capture the command if we don't have one yet
if not defined CMD (
set "CMD=%~1"
echo Command set to: %~1
shift
if "%1"=="" (
echo ERROR: --version requires a value
exit /b 1
)
set "LIVEKIT_VERSION=%1"
goto parse_all
)

:: 2. Check for the version flag
if /I "%~1"=="--version" (
shift
goto parse_args
goto :get_version_value
)

echo ERROR: Unknown option: %1
:: 3. Handle unknown arguments
echo ERROR: Unknown option: %~1
exit /b 1

:get_version_value
echo 1 after shift is : %~1
set "LIVEKIT_VERSION=%~1"
shift
goto parse_all

:after_parse
if not defined CMD (
echo ERROR: No command specified
goto usage
)

if defined LIVEKIT_VERSION (
set "CMAKE_EXTRA_ARGS=-DLIVEKIT_VERSION=%LIVEKIT_VERSION%"
echo ==^> Injecting LIVEKIT_VERSION=%LIVEKIT_VERSION%
Expand Down
Loading