Fix Meta Quest audio capture failures by making sample rate and channels configurable #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix audio capture failures on Meta Quest devices caused by sample_rate and num_channels mismatch with hardcoded defaults. Changes: - RtcAudioSource: Add optional uint? sampleRate parameter with platform-specific fallbacks - MicrophoneSource: Accept configurable channels and sampleRate at runtime - Allows device-specific audio configuration to match actual capabilities Fixes: InvalidState error - sample_rate and num_channels don't match
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Audio capture on Meta Quest devices fails with:
LiveKit: Audio capture failed: an RtcError occured: InvalidState - sample_rate and num_channels don't match
This occurs because the audio source uses hardcoded default sample rates that don't match what the device actually provides.
Solution
Make
RtcAudioSourceandMicrophoneSourceaccept optionalsampleRateandchannelsparameters at runtime instead of relying on hardcoded platform defaults. This allows configuration to match device capabilities.Changes
uint? sampleRateparameter to constructor with intelligent fallback to platform defaultschannelsandsampleRateparameters to constructor (defaults: 2 channels, 48000 Hz)Microphone.Start()instead ofDefaultMicrophoneSampleRateNotes