Conversation
b840af4 to
828e930
Compare
828e930 to
e7f6f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
A user-land component wrapping Flux components passes a
labelprop:The problem
The
labelprop leaks from the parent component into all children.This happens because
<flux:delegate-component>forwards inherited data from the entire component stack.Combined with
{{ $label ?? $slot }}, every option displays "Industry".The solution
Reverse the priority from
{{ $label ?? $slot }}to{{ $slot->isNotEmpty() ? $slot : $label }}across 9 files where this pattern occurs. Slot content now wins when present;labelprop still works as fallback for self-closing tags.Risk assessment
$slot->isNotEmpty()pattern is already used elsewhere in the codebase<flux:radio label="Foo" />) produce an empty slot, so$labelis still used as fallbackThe problematic pattern would be:
Before this change: Renders
FooAfter this change: Renders
BarFlux Pro PR: livewire/flux-pro#436
Fixes #2300