Open
Conversation
This line caused errors for me in the later "for (tt in tidxs)" loops. The timestamps get converted to numeric in the loop, causing it to throw an "out of bonds" error. This is a simple proposed change that fixed it for me. This actually gets the indeces instead of the timestamps.
arianasp
reviewed
Sep 12, 2025
Contributor
arianasp
left a comment
arianasp
left a comment
There was a problem hiding this comment.
Sorry for taking so long to look at this. I think this may be a problem with what you are putting into the function and not actually a problem with the function itself (unless I'm wrong). t0 and tf should be numeric values already (i.e. time indexes, not timestamps). So I have not approved this change for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line caused errors for me in the later "for (tt in tidxs)" loops. The timestamps get converted to numeric in the loop, causing it to throw an "out of bonds" error. This is a simple proposed change that fixed it for me. This actually gets the indeces instead of the timestamps.