-
Notifications
You must be signed in to change notification settings - Fork 42
Change Hyphens to Underscores to Match Spack1.0 Syntax #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmckinsey1
wants to merge
7
commits into
develop
Choose a base branch
from
underscore-names
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7b63c1 to
8183cec
Compare
Collaborator
Author
|
I thought this would work but |
Collaborator
Author
|
Update: this PR is waiting until @scheibelp gets a chance to take a look. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1091 +/- ##
========================================
Coverage 65.43% 65.43%
========================================
Files 44 44
Lines 3240 3240
Branches 256 256
========================================
Hits 2120 2120
Misses 1113 1113
Partials 7 7
🚀 New features to boost your workflow:
|
bbaba94 to
6cfa837
Compare
Collaborator
Author
|
dryruns should at least be passing now (I tested locally). Not sure about gitlab tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application
ci
CI, unit tests, GitHub actions
experiment
New or modified experiment
feature
New feature or request
system
New or modified system config
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding/modifying a benchmark (docs: Adding a Benchmark)
repo/*