-
Notifications
You must be signed in to change notification settings - Fork 2
restructure and deprecate zindex
#26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates the zindex library and replaces it with a new in-house DFTracerIndexer from the dftracer-utils package. The change aims to improve indexing and reading performance for trace files.
Key changes:
- Replace
zindex_pydependency withdftracer-utilspackage - Refactor file indexing to use
DFTracerIndexerinstead ofzindex - Modify batch processing to work with byte offsets rather than line numbers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates dependency from zindex_py to dftracer-utils package |
| dfanalyzer/dftracer.py | Replaces zindex implementation with DFTracerIndexer and refactors processing logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 57.48% 66.91% +9.42%
==========================================
Files 26 26
Lines 2164 2167 +3
==========================================
+ Hits 1244 1450 +206
+ Misses 920 717 -203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77c8ff1 to
c7a9676
Compare
|
please wait until we have new version of dftracer-utils then we can get this merged |
zindex and introduce DFTracerIndexerzindex
0b32944 to
f102ef8
Compare
edec548 to
ea0a030
Compare
hariharan-devarajan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
hi @izzet and @hariharan-devarajan
this PR aims to deprecate
zindexand using our in-house indexerDFTracerIndexer.This integration and whole PR is done but let's merge it until we have
dftracer-utilspackage later in pypi.I changed small lines of code as well so it should be easy to review.
My initial finding it improves the speed of indexing and reading.
[UPDATED] 10/21/2025
the file info is as follow
gzip -l trace.pfw.gz compressed uncompressed ratio uncompressed_name 784954304 (784.954304 MB) 5566780464 (5.566780464 GB) 85.9% trace.pfwhyperfine --warmup 3 "./build/bin/dftracer_reader trace.pfw.gz --start 10000000 --end 20000000 --mode lines --read-buffer-size $((1 * 1024 * 1024))" Benchmark 1: ./build/bin/dftracer_reader trace.pfw.gz --start 10000000 --end 20000000 --mode lines --read-buffer-size 1048576 Time (mean ± σ): 540.1 ms ± 3.3 ms [User: 492.7 ms, System: 45.4 ms] Range (min … max): 537.1 ms … 546.1 ms 10 runsTakeaways