[openmp] Build doxygen in bootstrapping builds #178298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meinersbur
requested review from
andreil99,
boomanaiden154,
ldionne,
llvm-beanz,
petrhosek and
tstellar
boomanaiden154
approved these changes
Jan 27, 2026
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM, but might want to let someone more knowledgeable about CMake also review.
Are there any other runtimes that also publish doxygen docs that we would want to do this for?
petrhosek
reviewed
Jan 27, 2026
Comment on lines
+261
to
+266
| if (LLVM_ENABLE_DOXYGEN) | ||
| list(APPEND extra_targets "doxygen-openmp") | ||
| if (TARGET doxygen) | ||
| add_dependencies(doxygen doxygen-openmp) | ||
| endif () | ||
| endif () |
Member
There was a problem hiding this comment.
I'd like to find a way to generalize this because hardcoding this for every runtime doesn't scale. Ideally, every runtime would provide doxygen-${runtime_name} target similarly to install-${runtime_name} above. That doesn't have to happen in this PR though, but I'd appreciate if you could at least leave a TODO comment here.
petrhosek
approved these changes
Jan 27, 2026
Member
Author
openmp is the only one. While there is a The proposed solution to add a |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/22304 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
LLVM_ENABLE_DOXYGEN=ON, forward thedoxygen-openmpbuild target from the nested (default target) runtimes build. WhenLLVM_BUILD_DOCS=ON, also triggerdoxygen-buildwithninja doxygen.LLVM_INCLUDE_DOCS=ONis required in the runtimes build, which is the default.This is required to update the OpenMP doxygen documentation at https://openmp.llvm.org/doxygen by the publish-doxygen-docs buidbot, discussed here: llvm/llvm-zorg#716 (review)