make missing -kernel error message less confusing#31
Merged
Conversation
Passing a non-existing local path to -kernel currently gives a confusing
error message. For example `-kernel ./foo/bar` causes:
Error: exec: retrieve kernel from OCI image: [...]
fetch image: get from remote: Get "https://./v2/":
dial tcp: lookup . on 127.0.0.53:53: no such host
This is because we try to resolve the kernel as an OCI image if a local
file doesn't exist.
Make this a bit less confusing by returning a better error message in
the common case where someone uses a "rooted" path like
/foo, ./foo or ../foo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a non-existing local path to -kernel currently gives a confusing error message. For example
-kernel ./foo/barcauses:This is because we try to resolve the kernel as an OCI image if a local file doesn't exist.
Make this a bit less confusing by returning a better error message in the common case where someone uses a "rooted" path like /foo, ./foo or ../foo.