Open
Conversation
| ENTRYPOINT ["node", "-r", "esm", "./bin/server"] | ||
| RUN npm run build | ||
|
|
||
| FROM node:22-alpine |
raul338
reviewed
Jul 26, 2025
raul338
left a comment
raul338
left a comment
There was a problem hiding this comment.
Nice work!!
Just leaving my 2 cents here.
I'm testing this branch with the official client version 2.0.2 installed using npm, with these changes it works mostly fine.
| secure: opts.secure, | ||
| domain: opts.domain, | ||
| landing: opts.landing, | ||
| secret: opts.secret, |
| .option('--domain, -d <string>', 'Specify the base domain name. This is optional if hosting localtunnel from a regular example.com domain. This is required if hosting a localtunnel server from a subdomain (i.e. lt.example.dom where clients will be client-app.lt.example.com)') | ||
| .option('--landing, -l <string>', 'The landing page for redirect from root domain', 'https://localtunnel.github.io/www/') | ||
|
|
||
| .option('--max-sockets', 'maximum number of tcp sockets each client is allowed to establish at one time (the tunnels)', intParser, 10) |
There was a problem hiding this comment.
should be '--max-sockets <number>' as first parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I invested some time to upgrade dependencies and also moved to typescript (I know, it is an opinonated choice).
I also filtered out some PR and added them manually.
client counterpart localtunnel/localtunnel#709