Add integration tests with Testcontainers and JUnit 5 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a comprehensive integration test suite using JUnit 5, Testcontainers (Elasticsearch 8.17.0), and AssertJ. Tests cover: - RestClientOperations: index creation, lock CRUD, migration record CRUD, query execution against real Elasticsearch - ElasticsearchDocumentLock: lock/unlock, tryLock with timeout, cross-thread contention behavior - MigrationFileLoader: YAML file discovery, version ordering, checksum stability, metadata parsing - Esque (end-to-end): full migration execution, idempotency, independent migration keys, user tracking, history recording Infrastructure: - Shared singleton ElasticsearchContainer via AbstractElasticsearchIT base class - maven-failsafe-plugin for *IT.java test execution during mvn verify - JUnit 5 BOM (5.11.4) and Testcontainers BOM (1.20.4) in parent POM - Test migration YAML files and logback-test.xml configuration https://claude.ai/code/session_01TXc3z5cZfH1omt6ys9uc6H
- Fix HttpHost construction to include explicit "http" scheme. getHttpHostAddress() returns host:port without a scheme, so HttpHost.create() produced a null-scheme host that failed to connect. - Fix execute_differentKeysAreIndependent test: two keys running the same migration files tried to PUT the same ES indices, causing resource_already_exists_exception on the second run. Restructured to verify key isolation by checking one key has records and the other doesn't. - Remove unused assertThatThrownBy import from EsqueIT. https://claude.ai/code/session_01TXc3z5cZfH1omt6ys9uc6H
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive integration tests for the Esque migration framework using Testcontainers to manage an Elasticsearch container and JUnit 5 as the testing framework.
Key Changes
*ITclasses)AbstractElasticsearchITthat manages a shared singleton Elasticsearch container and provides cleanup between testsEsqueIT: Tests core migration execution, idempotency, history recording, and multi-key independenceElasticsearchDocumentLockIT: Tests distributed locking mechanism with concurrent scenariosRestClientOperationsIT: Tests low-level Elasticsearch operations (index creation, migration records, lock management)MigrationFileLoaderIT: Tests migration file discovery and parsing from classpath resourcesV1.0.0__CreateTestIndex.yml, etc.) and logback test configurationNotable Implementation Details
RestClientinstances to simulate concurrent/multi-process scenariossrc/test/resources/es.migration/directory@BeforeEachto ensure test isolationhttps://claude.ai/code/session_01TXc3z5cZfH1omt6ys9uc6H