Pause study when max responses limit is reached#1832
Draft
becky-gilbert wants to merge 6 commits intoadd-max-responses-to-studyfrom
Draft
Pause study when max responses limit is reached#1832becky-gilbert wants to merge 6 commits intoadd-max-responses-to-studyfrom
becky-gilbert wants to merge 6 commits intoadd-max-responses-to-studyfrom
Conversation
…ax responses value, is active, and has reached limit; update pause trigger to make caller/user arg optional
11 tasks
11 tasks
…date or treated as changed because of None vs empty string comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This addresses part of #1829 but should not close the issue.
This PR adds logic to the Study model's
check_and_pause_if_at_max_responsesmethod. This method checks if the study:And if all of the above is true, it automatically pauses the study.
The pause transition triggers a notification email sent to site admins. This callback had to be edited to allow the caller (a user) to be an optional argument, since we've now added the ability for study states to change without a user/caller.
This PR also adds tests for the
check_and_pause_if_at_max_responsesmethod.To do:
check_and_pause_if_at_max_responsesmethod at all necessary points/events:check_and_pause_if_at_max_responsesmethod to include additional triggers that are not included in the user-invoked pause transition: