Skip to content

Fix rewindOnResize reset for infinite #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lleukkun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix rewindOnResize reset for infinite #680

lleukkun wants to merge 1 commit into from

Conversation

@lleukkun
Copy link

@lleukkun lleukkun commented Jun 26, 2017

Default behaviour is to reset, but when rewindOnResize = false,
we stick to the current slide. Also cleaned up the index
handling for infinite.

Signed-off-by: Lauri Leukkunen lauri.leukkunen@kajuutta.com

Fix rewindOnResize reset for infinite
b4c9692 
Default behaviour is to reset, but when rewindOnResize = false,
we stick to the current slide. Also cleaned up the index
handling for infinite.

Signed-off-by: Lauri Leukkunen <lauri.leukkunen@kajuutta.com>
@nstanard nstanard requested review from meandmax and nstanard June 28, 2017 19:19
@lleukkun
Copy link
Author

lleukkun commented Jul 10, 2017

Any opinions? Without this Lory is quite unusable on mobile for me and isn't that good on desktop either when resizing windows and using "infinite". This is a direct fix for #433 and mitigates #682 so it doesn't result in unusable mobile experience, at least when using infinite.

@andyrue
Copy link

andyrue commented Jul 19, 2017

This fix worked great. Thanks. Hope to see it merged and published to official soon.

@meandmax
Copy link
Collaborator

meandmax commented Jul 30, 2017

Thank you very much vor contributing! Please align your commits to https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit, otherwise semantic release doesnt know what to do.

meandmax
meandmax requested changes Aug 11, 2017
View reviewed changes
src/lory.js
translate(slides[index + infinite].offsetLeft * -1, 0, null);

index = index + infinite;
translate(slides[index].offsetLeft * -1, 0, null);
Copy link
Collaborator

@meandmax meandmax Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks sliders with multiple slides to scroll because you translate to the wrong slide if you hardly set this to 1

@Teun87
Copy link

Teun87 commented Feb 1, 2018

This problem is still present. Please make rewindOnResize work!

@garygreen
Copy link

garygreen commented Aug 8, 2018

I'm struggling to understand the whole rewindOnResize option. Why is the slide reset to the first slide when you resize the window? It seems bizzare to even be an option to me. Surely you would expect to remain on the same slide when you resize the window, not jump around. Never seen any other carousel implement such functionality

@silllli
Copy link

silllli commented Aug 21, 2018

@garygreen I am wondering about the same. How do you get rid of this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meandmax meandmax meandmax requested changes

@nstanard nstanard Awaiting requested review from nstanard

Assignees

@lleukkun lleukkun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lleukkun @andyrue @meandmax @Teun87 @garygreen @silllli