Skip to content

[otbn] OTBN instruction set for gnu-as #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrea-caforio wants to merge 1 commit into
base: binutils-2_44-unratified-bitmanip
Choose a base branch
from
Open

[otbn] OTBN instruction set for gnu-as #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions bfd/elfxx-riscv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,6 +1335,7 @@ static struct riscv_supported_ext riscv_supported_std_ext[] =
{"b", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
{"v", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
{"h", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
{"+", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
{NULL, 0, 0, 0, 0}
};

Expand Down Expand Up @@ -1618,7 +1619,7 @@ riscv_recognized_prefixed_ext (const char *ext)
}

/* Canonical order for single letter extensions. */
static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvnh";
static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvnh+";

/* Array is used to compare the orders of standard extensions quickly. */
static int riscv_ext_order[26] = {0};
Expand Down Expand Up @@ -1788,6 +1789,7 @@ riscv_get_default_ext_version (enum riscv_spec_class *default_isa_spec,
table = riscv_supported_std_ext;
}


Copy link
Collaborator

@ziuziakowska ziuziakowska Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra newline

int i = 0;
while (table != NULL && table[i].name != NULL)
{
Expand Down Expand Up @@ -1938,7 +1940,7 @@ riscv_parse_extensions (riscv_parse_subset_t *rps,
const char *p)
{
/* First letter must start with i, e or g. */
if (*p != 'e' && *p != 'i' && *p != 'g')
if (*p != 'e' && *p != 'i' && *p != 'g' && *p != '+')
{
rps->error_handler
(_("%s: first ISA extension must be `e', `i' or `g'"),
Comment on lines -1941 to 1946
Copy link
Collaborator

@ziuziakowska ziuziakowska Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message below should also include this new letter.

Expand Down Expand Up @@ -2569,6 +2571,8 @@ riscv_multi_subset_supports (riscv_parse_subset_t *rps,
{
case INSN_CLASS_I:
return riscv_subset_supports (rps, "i");
case INSN_CLASS_OTBN:
return riscv_subset_supports (rps, "+");
case INSN_CLASS_ZICBOM:
return riscv_subset_supports (rps, "zicbom");
case INSN_CLASS_ZICBOP:
Expand Down Expand Up @@ -2854,6 +2858,8 @@ riscv_multi_subset_supports_ext (riscv_parse_subset_t *rps,
{
case INSN_CLASS_I:
return "i";
case INSN_CLASS_OTBN:
return "+";
case INSN_CLASS_ZICBOM:
return "zicbom";
case INSN_CLASS_ZICBOP:
Expand Down
Loading