Open
Conversation
dulgheriubogdan
requested review from
AMihneaa,
MDGcode,
TeoStorm7 and
cristim67
cristim67
reviewed
Nov 15, 2023
client/src/components/Locatie.js
Outdated
Comment on lines
19
to
21
|
|
||
| //vrem vreme buna muie lu furtuna ca nu ne-a lasat sa punem animatia | ||
|
|
cristim67
reviewed
Nov 15, 2023
client/src/components/Locatie.js
Outdated
| </div> | ||
| <div className="flex-wrap rounded-lg pb-16 "> | ||
| <div className="relative w-[90%] md:w-4/6 w-4/5 rounded-lg mx-auto mt-16 border-4 border-[#78e800] shadow-inner "> | ||
| <img className="w-full rounded-lg" src={TestWebp} alt="Imagine" /> |
Collaborator
There was a problem hiding this comment.
more suggestive alt value
cristim67
reviewed
Nov 15, 2023
client/src/components/Program.js
Outdated
| </div> | ||
| <div className="flex-wrap rounded-lg pb-16 "> | ||
| <div className="relative w-[90%] md:w-4/6 w-4/5 rounded-lg mx-auto mt-16 border-4 border-[#78e800] shadow-inner "> | ||
| <img className="w-full rounded-lg" src={TestWebp} alt="Imagine" /> |
cristim67
reviewed
Nov 15, 2023
Comment on lines
19
to
21
|
|
||
| //vrem vreme buna muie lu furtuna ca nu ne-a lasat sa punem animatia | ||
|
|
cristim67
reviewed
Nov 15, 2023
client/src/components/Program.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| import TestWebp from "../assets/img/webp/Indrumar/program.webp"; | |||
Collaborator
There was a problem hiding this comment.
change this name with : ProgramPicture or something
cristim67
reviewed
Nov 15, 2023
client/src/components/Locatie.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| import TestWebp from "../assets/img/webp/Indrumar/harta.webp"; | |||
Collaborator
There was a problem hiding this comment.
change this name with LocationPicture or something
cristim67
reviewed
Nov 15, 2023
client/src/views/Home.js
Outdated
Comment on lines
17
to
18
| import Locatie from "../components/Locatie"; | ||
| import Program from "../components/Program"; |
Collaborator
There was a problem hiding this comment.
if the components name were in English, why did you name these in Romanian?
cristim67
reviewed
Nov 15, 2023
| @@ -43,6 +43,7 @@ | |||
| ] | |||
| }, | |||
| "devDependencies": { | |||
cristim67
approved these changes
Nov 15, 2023
…tion to the images, changed from romanian to english names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…petition