Skip to content

Add a replacement for MinecraftArgumentTypes#26

Open
Revxrsal wants to merge 2 commits intolucko:masterfrom
Revxrsal:master
Open

Add a replacement for MinecraftArgumentTypes#26
Revxrsal wants to merge 2 commits intolucko:masterfrom
Revxrsal:master

Conversation

@Revxrsal
Copy link

@Revxrsal Revxrsal commented Jun 16, 2022

Since the original MinecraftArgumentTypes required too much maintenance and reflection to work across all versions, it was removed in commodore 2.0. Unfortunately, my command library Lamp depended on it internally to provide support for entity selectors.

I've written a simple enum that constructs ArgumentTypes as needed. It does not hook into the registry or look up ArgumentTypes by their names internally. All it does is construct them, optionally with arguments.

Tested on Minecraft 1.13.2, 1.16.5, 1.17, and 1.19.

You may want to remove the MinecraftArgumentTypes.ensureSetup() call in CommodoreProvider. I didn't know whether to add it or not, so I added it anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant