Fix crash in macOS

.github/workflows/ci.yml

@@ -13,19 +13,19 @@ jobs:
           - name: Ubuntu
             version: latest
           - name: macOS
-            version: 12
+            version: latest
           - name: Windows
-            version: 2019
+            version: latest
         arch: [x64]
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '22'
           architecture: ${{ matrix.arch }}
 
       - name: Install dependencies and build from source
@@ -40,7 +40,7 @@ jobs:
         run: npm run prebuild
 
       - name: 'Upload prebuilt binaries'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: prebuilds-${{ matrix.os.name }}-${{ matrix.arch }}
           path: prebuilds
@@ -53,12 +53,12 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install Node.js with registry configured for publish
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
-          node-version: '16'
+          node-version: '22'
           registry-url: 'https://registry.npmjs.org'
 
       - name: Install dependencies without building

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-selection",
-  "version": "0.2.0-alpha.0",
+  "version": "0.2.0-alpha.1",
   "description": "Get current selected text by using system accessibility APIs",
   "gypfile": true,
   "main": "index.js",
@@ -18,11 +18,11 @@
     "prebuild:fat": "npm run prebuild -- --arch x64+arm64"
   },
   "dependencies": {
-    "node-addon-api": "^4.3.0",
-    "node-gyp-build": "^4.4.0"
+    "node-addon-api": "^8.3.1",
+    "node-gyp-build": "^4.8.4"
   },
   "devDependencies": {
-    "node-fetch": "^3.2.3",
-    "prebuildify": "^5.0.0"
+    "node-fetch": "^3.3.2",
+    "prebuildify": "^6.0.1"
   }
 }

src/selection_mac.mm

@@ -28,33 +28,28 @@ pid_t GetFrontProcessID() {
   if (!frontmostApplication) {
     return 0;
   }
-  pid_t pid = [frontmostApplication[@"NSApplicationProcessIdentifier"] intValue];
-  CFRelease(frontmostApplication);
-  return pid;
+  return [frontmostApplication[@"NSApplicationProcessIdentifier"] intValue];
 }
 
 std::optional<std::string> GetProcessName(pid_t pid) {
   auto application = [NSRunningApplication runningApplicationWithProcessIdentifier:pid];
   if (!application) {
-    return nil;
+    return std::nullopt;
   }
   auto url = [application executableURL];
   if (!url) {
-    CFRelease(application);
-    return nil;
+    return std::nullopt;
   }
   auto name = [url lastPathComponent];
-  CFRelease(application);
   return ToString(name);
 }
 
 std::optional<std::string> GetBundleIdentifier(pid_t pid) {
   auto application = [NSRunningApplication runningApplicationWithProcessIdentifier:pid];
   if (!application) {
-    return nil;
+    return std::nullopt;
   }
   auto bundle_identifier = [application bundleIdentifier];
-  CFRelease(application);
   return ToString(bundle_identifier);
 }
 
@@ -82,19 +77,21 @@ AXUIElementRef _GetFocusedElement(pid_t pid) {
     return nil;
   }
 
-  NSString *bundlerIdentifer = [NSString stringWithUTF8String:GetBundleIdentifier(pid)->c_str()];
+  auto bundleIdentifierOptional = GetBundleIdentifier(pid);
+  if (!bundleIdentifierOptional) {
+    return nil;
+  }
+  NSString *bundlerIdentifer = [NSString stringWithUTF8String:bundleIdentifierOptional->c_str()];
   if ([appsManuallyEnableAx containsObject:bundlerIdentifer]) {
     AXUIElementSetAttributeValue(application, CFSTR("AXManualAccessibility"), kCFBooleanTrue);
     AXUIElementSetAttributeValue(application, CFSTR("AXEnhancedUserInterface"), kCFBooleanTrue);
   }
-  CFRelease(bundlerIdentifer);
 
   AXUIElementRef focusedElement;
   auto error = AXUIElementCopyAttributeValue(application, kAXFocusedUIElementAttribute, (CFTypeRef *)&focusedElement);
   if (error != kAXErrorSuccess) {
     error = AXUIElementCopyAttributeValue(application, kAXFocusedWindowAttribute, (CFTypeRef *)&focusedElement);
   }
-  CFRelease(application);
   if (error != kAXErrorSuccess) {
     return nil;
   }