This repository was archived by the owner on Jan 16, 2018. It is now read-only.
added support for payload in DELETE requests#31
Open
twobitlabs wants to merge 1 commit intolukeredpath:masterfrom
Open
added support for payload in DELETE requests#31twobitlabs wants to merge 1 commit intolukeredpath:masterfrom
twobitlabs wants to merge 1 commit intolukeredpath:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that there's some contention about whether DELETE requests should support an HTTP body, but it's not forbidden in the spec, and you're often at the mercy of what the API developer defines, which is the case we ran into recently. Since it's contentious, I added one new method that includes a payload, rather than adding payload to all the existing methods. But I'd be happy to refactor the delete methods to all include a payload if you think that would be cleaner.