Skip to content

Conversation

@szepeviktor
Copy link
Contributor

🧪

@szepeviktor
Copy link
Contributor Author

Now it is working.

image

@xHeaven
Copy link
Member

xHeaven commented Dec 26, 2024

Thanks, I'll ignore a few errors for now that I don't see necessary to be fixed right now. (argument.templateType, missingType.iterableValue)

I'll also ignore trait.unused for now, because, to fix this error, I'd need to include tests/Enums in the scan (where the trait is used in the tests), which would raise quite a few "errors" that I'd have to fix, none of them which will actually cause any issues runtime, e.g.: the last() method returns \Callable|null, which actually is "not true", so I'd have to typehint that.

If you feel like you'd want to contribute to this, I'd appreciate it, otherwise I'll fix these issues later and roll out an update.

Edit: I understand that this effectively excludes the trait itself from the analysis, so I'll make sure to fix the issues as soon as possible.

@xHeaven xHeaven marked this pull request as ready for review December 26, 2024 21:54
@xHeaven xHeaven merged commit 013f7f5 into luminarix:main Dec 26, 2024
4 of 5 checks passed
@szepeviktor szepeviktor deleted the patch-2 branch December 27, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants