This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Handle boolean properties properly #490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where boolean properties of the `instance’ resource were getting overriden by default values when they were set to false. Fixes lusis#489 Signed-off-by: Bogdan Katynski <bogdan.katynski@workday.com>
After adding some extra logic to handle boolean parameters, RuboCop AbcSize and PerceivedComplexity cops started alarming. Disabling them for the load_current_resource method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where boolean properties
of the `instance’ resource were getting overriden
by default values when they were set to false.
Fixes #489
Signed-off-by: Bogdan Katynski bogdan.katynski@workday.com