Skip to content

Add RVC4 discovery and a notice to use v3.x version for RVC4 devices #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moratom merged 2 commits into from
Mar 17, 2025
Merged

Add RVC4 discovery and a notice to use v3.x version for RVC4 devices #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7524675
Add RVC4 discovery and a notice to use v3.x version for RVC4 devices
Mar 14, 2025
4545b69
Update core
Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion depthai-core
Open in desktop
Submodule depthai-core updated 4 files
+2 −2 cmake/Hunter/config.cmake
+4 −1 include/depthai/xlink/XLinkConnection.hpp
+8 −4 src/device/DeviceBase.cpp
+4 −3 src/xlink/XLinkConnection.cpp
11 changes: 9 additions & 2 deletions src/DeviceBindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "depthai-shared/device/CrashDump.hpp"

// std::chrono bindings
#include <XLink/XLinkPublicDefines.h>
#include <pybind11/chrono.h>
// py::detail
#include <pybind11/detail/common.h>
Expand Down Expand Up @@ -41,8 +42,14 @@ static auto deviceSearchHelper(Args&&... args){
auto numConnected = DEVICE::getAllAvailableDevices().size();
if(numConnected > 0) {
throw std::runtime_error("No available devices (" + std::to_string(numConnected) + " connected, but in use)");
} else {
throw std::runtime_error("No available devices");
}
auto numDevicesAnyPlatform = dai::XLinkConnection::getAllConnectedDevices(X_LINK_ANY_STATE, false, X_LINK_ANY_PLATFORM).size();
auto numDevicesRVC2 = dai::XLinkConnection::getAllConnectedDevices(
X_LINK_ANY_STATE, false, X_LINK_MYRIAD_X)
.size();
auto nonRVC2Devices = numDevicesAnyPlatform - numDevicesRVC2;
if(nonRVC2Devices > 0) {
throw std::runtime_error("No available RVC2 devices found, but found " + std::to_string(nonRVC2Devices) + " non RVC2 device[s]. To use RVC4 devices, please update DepthAI to version v3.x or newer.");
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/XLinkBindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ void XLinkBindings::bind(pybind11::module &m, void *pCallstack)
.def(py::init<const DeviceInfo &, std::vector<std::uint8_t> >())
.def(py::init<const DeviceInfo &, std::string>())
.def(py::init<const DeviceInfo &>())
.def_static("getAllConnectedDevices", &XLinkConnection::getAllConnectedDevices, py::arg("state") = X_LINK_ANY_STATE, py::arg("skipInvalidDevices") = true)
.def_static("getAllConnectedDevices", &XLinkConnection::getAllConnectedDevices, py::arg("state") = X_LINK_ANY_STATE, py::arg("skipInvalidDevices") = true, py::arg("platform") = X_LINK_MYRIAD_X)
.def_static("getFirstDevice", &XLinkConnection::getFirstDevice, py::arg("state") = X_LINK_ANY_STATE, py::arg("skipInvalidDevice") = true)
.def_static("getDeviceByMxId", &XLinkConnection::getDeviceByMxId, py::arg("mxId"), py::arg("state") = X_LINK_ANY_STATE, py::arg("skipInvalidDevice") = true)
.def_static("bootBootloader", &XLinkConnection::bootBootloader, py::arg("devInfo"))
Expand Down
Loading