Set abort lock true such that transactions are rescheduled properly.#3
Open
MWschutte wants to merge 1 commit intoluyi0619:masterfrom
Open
Set abort lock true such that transactions are rescheduled properly.#3MWschutte wants to merge 1 commit intoluyi0619:masterfrom
MWschutte wants to merge 1 commit intoluyi0619:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently transactions that abort are note being rescheduled.
In AriaManager line 139 function
cleanup_batchtakes care of rescheduling transactions that abort for the next epoch. Line 145: every transaction that has abort_lock is true will be rescheduled for execution next epoch. However now transactions will never be markedabort_locksince nothing is done when aborting the transactions. This PR fixes transactions not being rescheduled by marking them abort_locked when aborting.