feat: enable underscore integer separation for decimal values (ints)#204
Open
marcules wants to merge 1 commit intolyz-code:mainfrom
Open
feat: enable underscore integer separation for decimal values (ints)#204marcules wants to merge 1 commit intolyz-code:mainfrom
marcules wants to merge 1 commit intolyz-code:mainfrom
Conversation
a150cc0 to
dc84450
Compare
Pull Request Test Coverage Report for Build 3818872307Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lyz-code
requested changes
Jan 2, 2023
Owner
lyz-code
left a comment
There was a problem hiding this comment.
Thanks again for your time. I'd simply add another test to be sure
|
|
||
| result = fix_code(source, config) | ||
|
|
||
| assert result == fixed_source |
Owner
There was a problem hiding this comment.
Just to make sure I'd add a test where the source has underscores, the config is set to undersscore_integer = False and make sure that the reverse procedure works well too
fixed_source = dedent(
"""\
small_ints: [1, 10, 100]
big_ints: [1000, 10000, 1000000, 100000000000000000000]
"""
)
source = dedent(
"""\
---
small_ints: [1, 10, 100]
big_ints: [1_000, 10_000, 1_000_000, 100_000_000_000_000_000_000]
""" # noqa: E501
)
config = YamlfixConfig()
result = fix_code(source, config)
assert result == fixed_source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #202
Checklist